[Pythagorean Triplet]: Add Approaches #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I committed this to the wrong branch. Embarrassingly amateurish!
Suggestions and edits. Because we need to PR to a different repo, the `.svg` images have been removed, and the text adjusted.
|
@colinleach -- per our discussion, I removed the svg graphs. Is there anything else you'd like to change before we merge this? Just let me know -- thanks! |
|
No changes from me, at least at this stage. I reserve the right to change my mind when I see it live on Exercism - that can surface some hidden problems (as I discovered with |
uh oh! Hopefully, they got resolved quickly! ..and you can PR changes to this as needed! We also need to do dark/light versions of graphs at some point as well. But if this looks good-ish, Ima gonna merge! 🎉 |
BethanyG
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting lost in this. There are lots of files and quite a bit of repetition, so I'm not always sure what goes where.
I think most of the content is now in there somewhere. I'm submitting it for discussion, in the expectation that we may at least want to move things around.
@BethanyG : there's a placeholder for you in linear/content.md
You may wish to comment on your own submission!