Difference of squares: sync expected test results and input data with problem-specifications #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
suggested changes
May 28, 2019
| @@ -1,6 +1,7 @@ | |||
| import unittest | |||
|
|
|||
| from difference_of_squares import difference, square_of_sum, sum_of_squares | |||
| from difference_of_squares import difference_of_squares, \ | |||
| square_of_sum, sum_of_squares | |||
There was a problem hiding this comment.
It is preferable to use parenthesis instead of backslashes for multiline imports. Example:
from difference_of_squares import (
difference_of_squares,
square_of_sum,
sum_of_squares,
)There was a problem hiding this comment.
Ooops. I did not see this, or I wouldn't have closed this and deleted the branch. I am an idiot. :P Will re-open and correct!
…oding standards. Also corrected mis-named function in exercise stub.
Co-Authored-By: Corey McCandless <[email protected]>
cmccandless
approved these changes
May 31, 2019
|
Merged; thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1762
example.pyto conform withcanonical-data.json.example.pyto use the formulas from https://brilliant.org/wiki/sum-of-n-n2-or-n3/, rather than loops.example.pyand exercise stub to number from count.