Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown: update tests to v1.4.0 #1772

Closed
wants to merge 0 commits into from
Closed

markdown: update tests to v1.4.0 #1772

wants to merge 0 commits into from

Conversation

xitanggg
Copy link
Contributor

@xitanggg xitanggg commented May 3, 2019

This fixes #1752

@xitanggg xitanggg requested a review from a team as a code owner May 3, 2019 07:19
cmccandless
cmccandless suggested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Travis build:

$ flake8
./exercises/markdown/markdown_test.py:74:1: E305 expected 2 blank lines after class or function definition, found 1

@cmccandless
Copy link
Contributor

@xitanggg Looks like the example solution does not pass the new test. You'll need to update example.py to pass the new case.

@xitanggg
Copy link
Contributor Author

Sorry I have been traveling for the past few days. I will fix it soon.

@xitanggg xitanggg closed this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccandless cmccandless cmccandless requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

markdown: update tests to v1.4.0
2 participants
@xitanggg @cmccandless