Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'math' topic to relevant exercises in track config #1436

Merged
merged 3 commits into from
Aug 7, 2018

Conversation

kytrinyx
Copy link
Member

@kytrinyx kytrinyx commented Aug 4, 2018

The new site lets people filter optional exercises by topic, and this
makes it easy for people to skip past them.

This is important since the math-y exercises are not key to learning
the language, and a lot of people find them intimidating and demotivating.

This updates any 'mathematics' topics to be 'math' since it's shorter
and won't get cropped in the UI.

It also removes the math topics for any exercises that are not in the
canonical math-y list.

exercism/exercism#4110

The new site lets people filter optional exercises by topic, and this
makes it easy for people to skip past them.

This is important since the math-y exercises are not key to learning
the language, and a lot of people find them intimidating and demotivating.

This updates any 'mathematics' topics to be 'math' since it's shorter
and won't get cropped in the UI.

It also removes the math topics for any exercises that are not in the
canonical math-y list.
Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there were a lot of exercises in this track that had the mathematics topic incorrectly applied. Glad to see that cleaned up.

@@ -640,7 +636,6 @@
"conditionals",
"lists",
"loops",
"mathematics",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that this exercise is still relevant to the math topic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing discussion in exercism/exercism#4110, I am OK with removing this topic from this exercise.

@@ -640,7 +636,6 @@
"conditionals",
"lists",
"loops",
"mathematics",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing discussion in exercism/exercism#4110, I am OK with removing this topic from this exercise.

@cmccandless cmccandless merged commit 374bc86 into master Aug 7, 2018
@cmccandless cmccandless deleted the maths-exercises branch August 7, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants