Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale-generator: update README to latest description #1374

Merged
merged 2 commits into from
Apr 16, 2018
Merged

scale-generator: update README to latest description #1374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09fc2bc
scale-generator: clarify docs.
mrcfps Apr 14, 2018
ca13ff9
Merge branch 'master' into scale-generator-readme-update
cmccandless Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions exercises/scale-generator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ Given a tonic, or starting note, and a set of intervals, generate
the musical scale starting with the tonic and following the
specified interval pattern.

Scales in Western music are based on the chromatic (12-note) scale.This
Scales in Western music are based on the chromatic (12-note) scale. This
scale can be expressed as the following group of pitches:

A, A#, B, C, C#, D, D#, E, F, F#, G, G#

A given sharp note (indicated by a #), can also be expressed as the flat
of the note above it (indicated by a b), so the chromatic scale can also be
A given sharp note (indicated by a #) can also be expressed as the flat
of the note above it (indicated by a b) so the chromatic scale can also be
written like this:

A, Bb, B, C, Db, D, Eb, E, F, Gb, G, Ab
Expand All @@ -20,9 +20,9 @@ collection. They have seven pitches, and are called diatonic scales.
The collection of notes in these scales is written with either sharps or
flats, depending on the tonic. Here is a list of which are which:

No Accidentals:
No Sharps or Flats:
C major
A minor
a minor

Use Sharps:
G, D, A, E, B, F# major
Expand All @@ -43,17 +43,10 @@ a "whole step" or "major second" (written as an upper-case "M"). The
diatonic scales are built using only these two intervals between
adjacent notes.

Non-diatonic scales can contain the same letter twice, and can contain other intervals.
Sometimes they may be smaller than usual (diminished, written "D"), or larger
(augmented, written "A"). Intervals larger than an augmented second have other names.

Here is a table of pitches with the names of their interval distance from the tonic (A).

| A | A# | B | C | C# | D | D# | E | F | F# | G | G# | A |
|:------:|:-------:|:-------:|:-------:|:-------:|:-------:|:-------:|:-------:|:-------:|:-------:|:-------:|:-------:|:------:|
| Unison | Min 2nd | Maj 2nd | Min 3rd | Maj 3rd | Per 4th | Tritone | Per 5th | Min 6th | Maj 6th | Min 7th | Maj 7th | Octave |
| | | Dim 3rd | Aug 2nd | Dim 4th | | Aug 4th | Dim 5th | Aug 5th | Dim 7th | Aug 6th | Dim 8ve | |
| | | | | | | Dim 5th | | | | | | |
Non-diatonic scales can contain other intervals. An "augmented first"
interval, written "A", has two interceding notes (e.g., from A to C or
Db to E). There are also smaller and larger intervals, but they will not
figure into this exercise.

## Exception messages

Expand Down