yacht: implement exercise

[mrcfps]

Implement exercise yacht. Canonical Data. Discussions are welcome!

[cmccandless]

Might I suggest return sum(n for n in dice if n == number)?

[mrcfps]

Good point! That's much more Pythonic.

[cmccandless]

Perhaps it would be better to use some sort of enumeration rather than strings? Example:

from collections import Counter
from functools import partial

YACHT = 0
ONES = 1
TWOS = 2
THREES = 3
FOURS = 4
FIVES = 5
SIXES = 6
FULL_HOUSE = 7
FOUR_OF_A_KIND = 8
LITTLE_STRAIGHT = 9
BIG_STRAIGHT = 10
CHOICE = 11


# Example test
import yacht
from yacht import score

class YachtTest(unittest.TestCase):
    def test_yacht(self):
        self.assertEqual(score([5, 5, 5, 5, 5], yacht.YACHT), 50)

[mrcfps]

I was taking the approach widely adopted in Python data science community, e.g. in pandas DataFrame.dropna(axis=0, how='any', thresh=None, subset=None, inplace=False) accepts strings 'any' and 'or' as its how argument. But then robot-simulator came to my mind, I guess enumeration would be better and more consistent in this series of exercises.

[cmccandless]

Enumeration also allows the user to use anything they wish for the constants in their implementation (strings, integers, etc) while still constraining enough for tests to be written.

[cmccandless]

I might suggest "difficulty": 2 (but I wouldn't insist on it).

Unfortunately, we do not have a good set of guidelines for determining exercise difficulty... Perhaps this is an issue worth raising.

[mrcfps]

Currently there are so many exercises with difficulty 1, some of which are much more difficult than this exercise. Maybe we'll reach a consensus on this exercise after discussions in #1370.

[cmccandless]

I would rather not have a new exercise held up by difficulty level discussion... Many exercises' difficulties require reevaluation; we may as well merge this one and add it to the list.

…

On Apr 9, 2018, 22:22, at 22:22, Marc Chan ***@***.***> wrote: mRcfps commented on this pull request. > @@ -148,6 +148,21 @@ "conditionals" ] }, + { + "uuid": "22f937e5-52a7-4956-9dde-61c985251a6b", + "slug": "yacht", + "core": false, + "unlocked_by": null, + "difficulty": 1, Currently there are so many exercises with difficulty 1, some of which are much more difficult than this exercise. Maybe we'll reach a consensus on this exercise after discussions in #1370. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #1368 (comment)

[mrcfps]

@cmccandless Of course we'll realize this new exercise first. And when it comes to difficulty reevaluation, I think it's a noteworthy issue for all language tracks.

[cmccandless]

@mrcfps merged; thanks for working on this!