Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minesweeper: check test version and update if necessary #998

Closed
N-Parsons opened this issue Oct 25, 2017 · 0 comments
Closed

minesweeper: check test version and update if necessary #998

N-Parsons opened this issue Oct 25, 2017 · 0 comments

Comments

@N-Parsons
Copy link
Contributor

As identified in #784, some of the tests currently don't reference the version number for the canonical-data.json that they are based on, minesweeper is one of them. In order to help with the ongoing maintenance of this track, we're in the process of checking the tests against the current version of the canonical-data.json - if they are up-to-date, then you can just add the version string, but if they are out-of-date, then the tests will need updating.

Tests should typically be ordered according to their order in the canonical data, since this makes it easier to check and update them in future. If you think that there's a better order, please let us know your reasoning in your PR.

If there are some additional tests that currently exist in this track but which aren't in the canonical data, these can be kept if you think that they are useful. They should be placed at the bottom of the test cases, and it would also be super-helpful if you could add a comment before them saying # Additional tests for this track to make it clear that they aren't part of the canonical data.

The version string should be placed just before the first test class and followed by a blank line. For this exercise, the version string is:

# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0

Test suite: exercism/python/exercises/minesweeper/minesweeper_test.py
Canonical data: exercism/problem-specifications/exercises/minesweeper/canonical-data.json

smalley added a commit to smalley/python that referenced this issue Oct 27, 2017
Add missing test version comment.
Add ordered tests with names matching canonical data descriptions.
Disable empty board tests which are incompatible with board class.
Move selected old tests to additional tests section. Closes exercism#998
smalley added a commit to smalley/python that referenced this issue Oct 30, 2017
Add missing test version comment.
Add ordered tests with names matching canonical data descriptions.
Disable empty board tests which are incompatible with board class.
Move selected old tests to additional tests section.
Convert no row/column tests to expect validation to raise ValueError.
Closes exercism#998
N-Parsons pushed a commit that referenced this issue Nov 13, 2017
* minesweeper: update tests to version 1.1.0

Add missing test version comment.
Add ordered tests with names matching canonical data descriptions.
Disable empty board tests which are incompatible with board class.
Move selected old tests to additional tests section.
Convert no row/column tests to expect validation to raise ValueError.
Closes #998

* minesweeper: update test data to canonical format 1.0.0

Update test data to borderless format which matches canonical data format.
Change board verification to not test for borders and default example to
properly return a completely empty board and account for new index when there
is no border.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants