-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
house: results are now nonsense... #1415
Comments
SummaryWhat should have been done in this exerciseReplace newlines with spaces. What was actually doneNewlines were removed. |
Well, actually, I think I said that newlines were appropriate ... but if you're going to destroy the structure of a poem by removing newlines, at least replace them with spaces. |
Forgive my previous concise reply. I simply meant that when this exercise was updated to match the canonical data, it was done incorrectly. The canonical data replaced newlines with spaces. |
Fair enough. Spaces are sufficient, though the canonical data should really never have been updated. That said, the stanza structure and its willingness to break up sentences is a concept somewhat reserved to the printing of (generally English) poetry.
…On Jul 10, 2018, 16:08 +0100, Corey McCandless ***@***.***>, wrote:
Forgive my previous concise reply. I simply meant that when this exercise was updated to match the canonical data, it was done incorrectly. The canonical data replaced newlines with spaces.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
#1354 seems to have fixed an apparent inconsistency in test data with the other "songs", but in doing so has made the actual results make no sense.
This:
expected = [
"This is the cat",
"that killed the rat",
"that ate the malt",
"that lay in the house that Jack built."
]
Was updated to this:
But that means that what was returned ["This is the cat", "that killed the rat", "that ate the malt", "that lay in the house that Jack built"] is now ["This is the catthat killed the ratthat ate the maltthat lay in the house that Jack built"] ... now you do indeed have a single sentence, but it's full of nonsense words.
The data may have appeared inconsistent by breaking up sentences, but I would argue that what it actually did was break up stanzas, which have no bearing on sentences. Poems (and songs) are traditionally delivered by breaking sentences up into stanzas, normally along either boundaries of meter or rhyme repetition.
The text was updated successfully, but these errors were encountered: