Normalizes topics to snake_case notation #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lately it seems to be good practice to keep .txt documents compatible with markdown. As that was the case in the original file, I would recommend keeping the previous header style and limiting this PR to the snake casing. This will also conflict with #888 (and potentially #886), should probably wait for #888 to be merged in, fix conflicts then this one would be good to go. |
|
@tleen, got it, thanks |
|
#888 is in 👍 snake_case that into this and we should be good to go! |
ilya-khadykin
force-pushed
the
issue_887_convert_topics_to_snake_case
branch
from
5e589c5 to
64adcff
Compare
|
@tleen, PR has been updated accordingly |
tleen
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to normalize topics to snake_case notation as discussed earlier.
Also relates to #888
Your feedback is welcomed