scrabble-score: add alphabet completeness test #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insti
approved these changes
Jan 27, 2017
|
Thanks for the quick review! |
|
LGTM |
|
Thanks! |
|
you're welcome! Thanks back for all the feedback! |
petertseng
added a commit
to exercism/haskell
that referenced
this pull request
Jan 31, 2017
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the discussion in #509 , here is proposed addition to the canonical data.
Feel free to pick nits!
If we really wish to stick to "proper, scrabble-approved word", I could make multiple cases for
"the"
"quick"
"brown"
"fox"
"jumps"
"over"
"lazy"
"dog"
But in my personal opinion that obscures the intended purpose. The complete alphabet is the shortest way to express the complete alphabet, and thereby makes the intent the clearest. Anything else just muddles the waters (IMHO).