run-length-encoding: Remove non-ASCII test cases #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Separate commit maybe, not a separate PR. Edit: Yeah, maybe two different PR's, seems like different subjects. Why the whitespace differences? |
behrtam
force-pushed
the
unicode-run-length
branch
from
97c4759 to
63957e4
Compare
behrtam
changed the title
|
Okay, removed the new test cases from this PR and fixed the unintentional changed white spaces (json auto formatter in my editor). |
kotp
approved these changes
Nov 5, 2016
|
Thanks @behrtam ❤️ |
|
Ref: #441 |
behrtam
added a commit
to behrtam/python
that referenced
this pull request
Mar 8, 2017
This removes the unicode test cases ([x-common/428](exercism/problem-specifications#428), [x-common/434](exercism/problem-specifications#434)) and adds the new white space and lowercase tests ([x-common/624](exercism/problem-specifications#624)).
behrtam
added a commit
to behrtam/python
that referenced
this pull request
Mar 8, 2017
This removes the unicode test cases (exercism/problem-specifications#428, exercism/problem-specifications#434) and adds the new white space and lowercase tests (exercism/problem-specifications#624).
behrtam
added a commit
to behrtam/python
that referenced
this pull request
Mar 16, 2017
This removes the unicode test cases (exercism/problem-specifications#428, exercism/problem-specifications#434) and adds the new white space and lowercase tests (exercism/problem-specifications#624).
behrtam
added a commit
to exercism/python
that referenced
this pull request
Mar 16, 2017
This removes the unicode test cases (exercism/problem-specifications#428, exercism/problem-specifications#434) and adds the new white space and lowercase tests (exercism/problem-specifications#624).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the two unicode test cases as discussed in #428.
I also added one test case with an empty string and one with only chars that occur once. If you would prefer those non unicode changes in a separate PR, just ask.