tournament: clarify behavior on invalid lines (ignore) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Only accept" was a bit vague - this commit changes the mesage to say that invalid line are ignored, and the tournament scored without them. This is in line with the behavior of all current tracks. If reviewers wish a change to this behavior, we can discuss that in a separate PR. (Note that the go track is an exception, but it clearly states it is an exception in its test suite visible to students) Closes #286 Closes exercism/rust#122
|
To make it clear, I don't like silently ignoring invalid inputs. I simply took the path of least resistance since it matched what all tracks were already doing. Were I given time to respecify this exercise, I would require that invalid lines result in errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Only accept" was a bit vague - this commit changes the mesage to say
that invalid line are ignored, and the tournament scored without them.
This is in line with the behavior of all current tracks. If reviewers
wish a change to this behavior, we can discuss that in a separate PR.
(Note that the go track is an exception, but it clearly states it is an
exception in its test suite visible to students)
Closes #286
Closes exercism/rust#122