sum-of-multiples: Note change in flight in README #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| numbers. If no set of numbers is given, default to 3 and 5. | ||
| numbers. | ||
|
|
||
| This exercise is in the process of being reworked. |
There was a problem hiding this comment.
Will this scare people off into thinking "maybe I shouldn't do this exercise"?
If so, I should explicitly say "You can still do this exercise and submit solutions, but the test cases may differ from the README"
As noted in exercism/discussions#2, while #198 to remove the [3, 5] defaults is in flight, we should mark it as such in the README. This avoids confusion in the form of "Oh, this track doesn't implement the defaults in the README, so I'll add them", reversing the work we've done to make the exercise consistent across all tracks.
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
improve beer song API and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in exercism/discussions#2, while #198
to remove the [3, 5] defaults is in flight, we should mark it as such in
the README.
This avoids confusion in the form of "Oh, this track doesn't implement
the defaults in the README, so I'll add them", reversing the work we've
done to make the exercise consistent across all tracks.