sum-of-multiples: describe the importance of each test #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent! |
sum-of-multiples 1.4.1 As stated in our guidelines, we want descriptions that tell us why each case is being tested: https://github.com/exercism/problem-specifications#test-data-format-canonical-datajson The canonical data was added in #206 during a time when descriptions were not required. Then, placeholder descriptions were added in aaa47ee and it was acknowledged at the time that these descriptions were purely for *schema* compliance, and not compliance with the guidelines nor a motivation for each case. By examining the issues that led to each case being added, it is possible to understand the descriptions. With more cases being added to sum-of-multiples with clear descriptions, it's time to bring the other descriptions up to speed as well. Original exercise: exercism/exercism@607be68 Additional cases: exercism/exercism#2486 exercism/exercism#2341 exercism/haskell#50 exercism/go#53 #896
|
I'll take that as a yes Also, it's 1.4.1 now since I merged #1367 before mine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sum-of-multiples 1.3.1
As stated in our guidelines, we want descriptions that tell us why each
case is being tested:
https://github.com/exercism/problem-specifications#test-data-format-canonical-datajson
The canonical data was added in
#206 during a
time when descriptions were not required.
Then, placeholder descriptions were added in
aaa47ee and it was acknowledged at the
time that these descriptions were purely for schema compliance, and
not compliance with the guidelines nor a motivation for each case.
By examining the issues that led to each case being added, it is
possible to understand the descriptions.
With more cases being added to sum-of-multiples with clear descriptions,
it's time to bring the other descriptions up to speed as well.
Original exercise:
exercism/exercism@607be68
Additional cases:
exercism/exercism#2486
exercism/exercism#2341
exercism/haskell#50
exercism/go#53
#896