Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple-Cipher: Added additional test case #1345

Closed
wants to merge 1 commit into from
Closed

Simple-Cipher: Added additional test case #1345

wants to merge 1 commit into from

Conversation

darthbob88
Copy link

There are more invalid keys for this exercise than just UPPER-CASE and numer1c.

@darthbob88
Added additional test case
9cd0ae4 
There are more invalid keys for this exercise than just UPPER-CASE and numer1c.
@rpottsoh rpottsoh changed the title Added additional test case simple-cipher: Added additional test case Oct 2, 2018
@rpottsoh rpottsoh changed the title simple-cipher: Added additional test case Simple-Cipher: Added additional test case Oct 2, 2018
@rpottsoh
Copy link
Member

rpottsoh commented Oct 2, 2018

closing in favor of #1316.

"Throws an error with a key containing a punctuation mark" in #1316 I think covers the proposed case in this PR. Furthermore I think this comment along with #902. need to be considered. It seems that this can be resolved more easily by updating the wording in description.md

@rpottsoh rpottsoh closed this Oct 2, 2018
@darthbob88 darthbob88 deleted the patch-1 branch October 2, 2018 17:36
@rpottsoh rpottsoh mentioned this pull request Oct 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darthbob88 @rpottsoh