Skip to content
This repository has been archived by the owner on Jan 29, 2021. It is now read-only.

Add and remove alumni automatically #4

Merged
merged 2 commits into from
May 31, 2018

Conversation

tombruijn
Copy link
Contributor

@tombruijn tombruijn commented May 12, 2018

Remove alumni automatically from alumni team

Remove the user from the alumni team when they are being added to
another team on the exercism GitHub organization. For example, when an
alumni rejoins a(nother) track.

This check uses the GitHub GraphQL API because it allowed for more
selective querying teams and members of teams.

Selectively add users to alumni team

Only add user to alumni team when they are not maintaining another
project, are not part of any other teams anymore.


Built in collaboration with @fabia88

Based on #3
Fixes issue: exercism/meta#2
Part of exercism/meta#100

Note: This does not take into consideration repositories with the "exercism-track" topic label yet. As discussed this is a feature, not a bug :)

@kytrinyx
Copy link
Member

Built in collaboration with @fabia88

🎉

For future reference, you can add a trailer to your git commit so that both people's avatars are referenced in the timeline: https://blog.github.com/2018-01-29-commit-together-with-co-authors/

Remove the user from the alumni team when they are being added to
another team on the exercism GitHub organization. For example, when an
alumni rejoins a(nother) track.

This check uses the GitHub GraphQL API because it allowed for more
selective querying teams and members of teams.

Co-authored-by: Fabia Moroni <[email protected]>
@tombruijn
Copy link
Contributor Author

@kytrinyx Good idea!
I'll reword the commits to include the co-author and force push the changes.
I'll let you know when I've pushed the changes.

Only add user to alumni team when they are not maintaining another
project, and are not part of any other teams anymore.

Co-authored-by: Fabia Moroni <[email protected]>
@tombruijn
Copy link
Contributor Author

@kytrinyx commits updated! Let me know if I need to do anything else :)

@kytrinyx
Copy link
Member

Awesome, thank you!

@kytrinyx kytrinyx merged commit 3e794db into exercism:master May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants