[Space-Age] - Change API to take planet as input #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rather than having multiple methods for each planet, just take it as input - makes the solution a lot simpler. * Also properly adheres to the [canonical tests](https://github.com/exercism/problem-specifications/blob/master/exercises/space-age/canonical-data.json). * Removes the last extra test to check for reassigning of seconds - which is not in canonical data.
tejasbubane
changed the title
tejasbubane
changed the title
|
I'm fine with this but that removes our "prototype based" exercise.
…On Thu, 24 Jan 2019, 11:25 Tejas Bubane, ***@***.***> wrote:
@tejasbubane <https://github.com/tejasbubane> requested your review on:
#598 <#598> [Space-Age] -
Change API for take planet as input.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#598 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB35WD6clEpDAe7LkOoLNPa2T4r3sBYLks5vGYoZgaJpZM4aQkAA>
.
|
I did not get what you mean here. |
|
Sorry. Check the mentor notes for this exercise. It will make more sense :D
I'll approve this now
…On Thu, 24 Jan 2019, 12:07 Tejas Bubane, ***@***.***> wrote:
but that removes our "prototype based" exercise.
I did not get what you mean here.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#598 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB35WH6zq6Jm_pcRxFTxHSOD60a9DVkhks5vGZPVgaJpZM4aQkAA>
.
|
Yes. 👍 I had it in mind to change mentor notes while making the change but forgot later. |
This was referenced Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having multiple methods for each planet, just take it as input - makes the solution a lot simpler.
Also properly adheres to the canonical tests.
Removes the last extra test to check for reassigning of seconds - which is not in canonical data.