Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high-scores: Implement exercise #537

Merged
merged 4 commits into from
Oct 30, 2018
Merged

high-scores: Implement exercise #537

merged 4 commits into from
Oct 30, 2018

Conversation

PakkuDon
Copy link
Contributor

New problem specification added in exercism/problem-specifications#1378

"core": false,
"unlocked_by": "acronym",
"difficulty": 2,
"topics": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the same core, unlocked_by, difficulty and topics as the Ruby track. Do these settings make sense for this track?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw the build. 😅 Apparently not

The command "bin/fetch-configlet" exited with 0.
0.19s$ bin/configlet lint .
-> The exercise 'high-scores' is being unlocked by a non-core exercise. Non-core exercises can only be unlocked by core exercises.

Anyone have any suggestions? Would anyone object to unlocked_by being set to null?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PakkuDon I'm thinking: have it be unlocked by pangram? Since that's the one that unlocks acronym?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I'll give that a try 👍

@matthewmorgan
Copy link
Contributor

Beauteous!

@matthewmorgan matthewmorgan merged commit 1853f06 into exercism:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants