all-your-base: add to track #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkent
changed the title
No love for the octal literal?!? :) |
jtigger
approved these changes
Dec 1, 2016
|
|
||
| public final class BaseConverterTest { | ||
|
|
||
| /* |
| @Test | ||
| public void testLeadingZeros() { | ||
| expectedException.expect(IllegalArgumentException.class); | ||
| expectedException.expectMessage("Digits may not contain leading zeros."); |
| public void testSecondBaseIsOne() { | ||
| final BaseConverter baseConverter = new BaseConverter(2, new int[]{1, 0, 1, 0, 1, 0}); | ||
|
|
||
| expectedException.expect(IllegalArgumentException.class); |
There was a problem hiding this comment.
All this time, I had anchor bias and put my ExpectedException rules at the top of the method (prior to the rule, we had the annotation parameter). But you are putting it immediately before the method that should emit the exception... I ❤️ this.
|
Note that per exercism/problem-specifications#279, the other base conversion exercises are considered deprecated. Let's keep that in mind with #142 and this exercise. |
|
@jtigger rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonical data here.
The test
both bases are negativewas skipped as it is redundant given the structure of this implementation.The canonical data also poses some questions for implementors, which I answered as follows:
[0][0]No.
By throwing an exception with an appropriate message.