-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anagram: Make the test suite as flexible as possible #393
Merged
petertseng
merged 1 commit into
exercism:master
from
rbasso:anagram-generalize-test-suite
Oct 12, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
## Hints | ||
|
||
To complete this exercise you need to implement the function `anagramsFor`, | ||
that takes a *word* and a group of *words*, returning the ones that are | ||
anagrams of the given *word*. | ||
|
||
If it is your first time solving this exercise, it is recommended that you | ||
stick to the provided signature: | ||
|
||
```haskell | ||
anagramsFor :: String -> [String] -> [String] | ||
``` | ||
|
||
Later, it may be a good idea to revisit this problem and play with other data | ||
types and libraries: | ||
|
||
- `Text`, from package *text*. | ||
- `Sequence` and `Set`, from package *containers*. | ||
- `MultiSet`, from package *multiset* | ||
|
||
The test suite was intentionally designed to accept almost any type signature | ||
that makes sense, so you are encouraged to find the one you think is the best. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,13 @@ | ||
module Anagram (anagramsFor) where | ||
import Data.List (sort) | ||
import Data.Char (toLower) | ||
|
||
anagramsFor :: String -> [String] -> [String] | ||
anagramsFor word = filter (isAnagram . normalize) | ||
import Data.Function (on) | ||
import Data.MultiSet (fromList) | ||
import Data.Set (Set, filter) | ||
import Data.Text (Text, toLower, unpack) | ||
import Prelude hiding (filter) | ||
|
||
anagramsFor :: Text -> Set Text -> Set Text | ||
anagramsFor x = filter (\w -> x `isDistinctOf` w && x `isAnagramOf` w) | ||
where | ||
normalize xs = let nxs = map toLower xs in (nxs, sort nxs) | ||
(nw, sw) = normalize word | ||
isAnagram (w, s) = nw /= w && sw == s | ||
isDistinctOf = (/=) `on` toLower | ||
isAnagramOf = (==) `on` fromList . unpack . toLower |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for my study - this allows either
Text
orString
to be used. Interesting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IsList is fantastic. Way more flexible than I imagined. 😄