Retrofit Groovy language track tests as Spock specifications #31

Dispader · 2016-10-27T00:46:12Z

Hey, everyone.

So— I should type up something more descriptive, but I'd rather start the process of having someone look at this Pull request (because I'm sure that it could use some work).

This Pull is an attempt to retrofit tests as Spock specifications for the Groovy track up through the phone-number exercise, as discussed in this Pull.

Other exercises seem to point to the Exercism.io documentation. Also, instructions for importing into IntelliJ (or other IDE) seems better off kept as advanced instructions. The tests can be run directly from the command line with edits in any editor (or IDE). These instructions may not be as complete as we'd like, but I feel we muddy the waters less by keeping the basic instructions on the simple side.

- Fix indentation - Make test cases match canonical - Implement IllegalArgumentException, per canonical data

kytrinyx · 2016-10-30T20:23:25Z

Thanks so much @Dispader!

@kimdbarnes do you have time to look at this? (I promise I'm going to look for Groovy track maintainers really, really soon ❤️!)

kimdhendrick

@ignore is misspelled in this sentence: "+After the first test(s) pass, continue by commenting out or removing the @Ingore annotations prepending other tests."

kimdhendrick · 2016-10-30T22:02:15Z

Except for the above misspelling, it looks good to me!

mattphillips · 2016-10-31T00:21:01Z

I see Gradle was briefly touched upon in #26 I'm just wondering why it's not being used over @Grab to manage dependencies like Spock. I think that understanding a build/ dependency management tool for a language is a vital part of learning the ecosystem?

mattphillips · 2016-10-31T00:34:58Z

exercises/difference-of-squares/SquaresSpec.groovy

+@Grab('org.spockframework:spock-core:1.0-groovy-2.4')
+import spock.lang.*
+
+class SquaresSpec extends Specification {


These test are a good chance to show off Spock's parameterised tests with something like this for each one:

@Unroll def 'can square the sum of the numbers up to the given number: #num'() { expect: new Squares(num).squareOfSums() == expected where: num || expected 5 || 225 10 || 3025 100 || 25502500 }

dvberkel · 2016-10-31T06:35:45Z

I think this is a accurate implementation of the various test using Spock.

I would give my 👍

gijsleussink · 2016-10-31T07:03:21Z

exercises/hello-world/HelloWorldSpec.groovy

+class HelloWorldSpec extends Specification {
+
+    def 'outputs "Hello, World!"'() {
+        expect: new HelloWorld().hello() == 'Hello, World!'


I would have the expect and other tags on separate lines.
And I would extract the class instantiation to a field.

@gijsleussink I was also wondering about this one— you think that we should introduce helloWorld as a test case variable?

I could get behind that, but I was almost considering making the call static, since our calls just output text, and don't modify any object state, which would make the calls HelloWorld.hello().

If we went as far as a static get method, the call could look like HelloWorld.hello.

Thoughts?

Yeah, in this case it simplifies. I read the Hello-World exercise and you mainly focus on getting the concept of TDD across. So why not keep the Spec as simple and easily readable as possible?

@gijsleussink What d'you think, sir?

gijsleussink · 2016-10-31T07:07:17Z

exercises/hamming/HammingSpec.groovy

+@Grab('org.spockframework:spock-core:1.0-groovy-2.4')
+import spock.lang.*
+
+class HammingSpec extends Specification {


Perhaps it's mentioned somewhere else (in the exercise?), but if I only look at this spec I wouldn't know (the overview of) what a Hamming-distance is and what the letters stand for

An exercise is assembled from various sources. For example, the description for The Hamming exercise can be found at x-common/exercises/hamming

tlberglund · 2016-10-31T16:14:00Z

@mattphillips I'm always 👍 on Gradle, but to my mind @Grab never gets enough love either. In this case it helps the code be more self-contained and removes environment setup tasks. I'm new to Exercism and may conceivably be missing the point, but I think we just want Groovy-based solutions to the standard Exercism programming problems. @Grab seems to me like the move in that case. 😀

mattphillips · 2016-10-31T22:39:24Z

@tlberglund I'm not a Groovy dev but @Grab seems to be a bit magical (I'm not sure why you would grab the same dependencies multiple times in different files), although it does fit this use case quite well 😃. However I'd say that learning a new language is not only about the core constructs and syntax but actually learning the ecosystem, which includes build/ dependency management tools like Gradle and how to write tests.

Dispader · 2016-11-01T00:33:32Z

SETUP.md

@@ -7,6 +7,6 @@ Run the tests by executing the test script.
 $ groovy ./HelloWorldSpec.groovy
 ```

-After the first test(s) pass, continue by commenting out or removing the `@Ingore` annotations prepending other tests.
+After the first test(s) pass, continue by commenting out or removing the `@Ignore` annotations prepending other tests.


Thanks @kimdbarnes !

tlberglund · 2016-11-01T15:19:07Z

Oh, @Grab is dark magick alright. But I think the structure of the overall Exercism project is that you solve the same programming problems in different languages. I don't think it's a general platform and language introduction. So I completely agree that Groovy is best built with Gradle and a good introduction to one entails a good introduction to the other, but I'd stand behind the use of @Grab here given the project scope. But I stress that this is merely my $2E-2. :)

kytrinyx · 2016-11-28T23:44:06Z

I'd say that learning a new language is not only about the core constructs and syntax but actually learning the ecosystem, which includes build/ dependency management tools like Gradle and how to write tests.

@mattphillips in general I'd agree, however on Exercism we're explicitly targeting a high level of fluency at only the language syntax / standard library / idioms / conventions level, not the larger platform / tool / real-world-codebase level.

kytrinyx · 2016-11-28T23:44:32Z

Thanks everyone, for the discussion!

Dispader added 8 commits October 12, 2016 15:38

Ingores Eclipse .project configuration file

7b8e54d

Implement HelloWorld test as Spock specification

2e68500

Implement Hamming test as Spock specification

ad238a0

Implement Gigasecond test as Spock specification

202fb46

Implement Raindrops test as Spock specification

f95f749

Implement RNA Transcription test as Spock specification

4bb382b

- Fix indentation - Make test cases match canonical - Implement IllegalArgumentException, per canonical data

Implement Squares test as Spock specification

ac2741a

Dispader changed the title ~~Retrofit spock~~ Retrofit Groovy language track tests as Spock specifications Oct 27, 2016

kimdhendrick suggested changes Oct 30, 2016

View reviewed changes

mattphillips reviewed Oct 31, 2016

View reviewed changes

gijsleussink reviewed Oct 31, 2016

View reviewed changes

Corrcet tpyo

9da46df

Dispader commented Nov 1, 2016

View reviewed changes

Use parameterized inputs in Squares specification

1cb0659

Extracts class instantiation in test

2710bf2

Dispader mentioned this pull request Nov 4, 2016

Gigasecond not working with Groovy 2.4.5? #29

Closed

kytrinyx merged commit 8fc4937 into exercism:master Nov 28, 2016

petertseng mentioned this pull request Feb 14, 2017

All tracks that have discussed whether to use a build system or not exercism/discussions#117

Closed

Dispader deleted the retrofit_spock branch February 23, 2017 05:27

Dispader mentioned this pull request Oct 11, 2017

Improvement for Travis CI #95

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Retrofit Groovy language track tests as Spock specifications #31

Retrofit Groovy language track tests as Spock specifications #31

Dispader commented Oct 27, 2016

kytrinyx commented Oct 30, 2016

kimdhendrick left a comment

kimdhendrick commented Oct 30, 2016 •

edited

Loading

mattphillips commented Oct 31, 2016

mattphillips Oct 31, 2016

dvberkel commented Oct 31, 2016 •

edited

Loading

gijsleussink Oct 31, 2016

Dispader Nov 1, 2016 •

edited

Loading

gijsleussink Nov 2, 2016

Dispader Nov 3, 2016

gijsleussink Oct 31, 2016

dvberkel Oct 31, 2016

tlberglund commented Oct 31, 2016

mattphillips commented Oct 31, 2016

Dispader Nov 1, 2016

tlberglund commented Nov 1, 2016

kytrinyx commented Nov 28, 2016

kytrinyx commented Nov 28, 2016

Retrofit Groovy language track tests as Spock specifications #31

Retrofit Groovy language track tests as Spock specifications #31

Conversation

Dispader commented Oct 27, 2016

kytrinyx commented Oct 30, 2016

kimdhendrick left a comment

Choose a reason for hiding this comment

kimdhendrick commented Oct 30, 2016 • edited Loading

mattphillips commented Oct 31, 2016

mattphillips Oct 31, 2016

Choose a reason for hiding this comment

dvberkel commented Oct 31, 2016 • edited Loading

gijsleussink Oct 31, 2016

Choose a reason for hiding this comment

Dispader Nov 1, 2016 • edited Loading

Choose a reason for hiding this comment

gijsleussink Nov 2, 2016

Choose a reason for hiding this comment

Dispader Nov 3, 2016

Choose a reason for hiding this comment

gijsleussink Oct 31, 2016

Choose a reason for hiding this comment

dvberkel Oct 31, 2016

Choose a reason for hiding this comment

tlberglund commented Oct 31, 2016

mattphillips commented Oct 31, 2016

Dispader Nov 1, 2016

Choose a reason for hiding this comment

tlberglund commented Nov 1, 2016

kytrinyx commented Nov 28, 2016

kytrinyx commented Nov 28, 2016

kimdhendrick commented Oct 30, 2016 •

edited

Loading

dvberkel commented Oct 31, 2016 •

edited

Loading

Dispader Nov 1, 2016 •

edited

Loading