Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse-string: improve tests with multibyte character strings? #1068

Closed
fabiopozzi opened this issue Feb 6, 2018 · 1 comment
Closed

reverse-string: improve tests with multibyte character strings? #1068

fabiopozzi opened this issue Feb 6, 2018 · 1 comment
Assignees
@leenipper

Comments

@fabiopozzi
Copy link

I don't know if it fits the original problem spirit, but given that Go supports UTF-8 it could be nice to insert a multibyte string example in the test suite.
I think that a simple string like the one used in the official website "Hello, 世界" could be a nice improvement.
@leenipper
Copy link
Contributor

Good suggestion.

@leenipper leenipper self-assigned this Feb 6, 2018
leenipper added a commit to leenipper/xgo that referenced this issue Feb 6, 2018
@leenipper
reverse-string: add UTF-8 multibyte test case
7811ed5 
Add reverseTestCase type in generator output to be
used in the test program.

Since file cases_test.go is generated from
problem-specifications/exercises/reverse-string/canonical-data.json,
add an additional test case for UTF-8 within the test program.

Resolves exercism#1068
@leenipper leenipper mentioned this issue Feb 6, 2018
Merged
@ferhatelmas ferhatelmas mentioned this issue Feb 8, 2018
Closed
leenipper added a commit that referenced this issue Feb 8, 2018
@leenipper
reverse-string: add UTF-8 multibyte test case (#1069)
1b2e419 
Add reverseTestCase type in generator output to be
used in the test program.

Since file cases_test.go is generated from
problem-specifications/exercises/reverse-string/canonical-data.json,
add an additional test case for UTF-8 within the test program.

Resolves #1068
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leenipper leenipper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabiopozzi @leenipper