Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the palindrome-products exercise #270

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

juhlig
Copy link
Contributor

@juhlig juhlig commented Aug 3, 2018

  • unlocked by accumulate since it is somehow similar to change and dominoes
  • difficulty of 6 (estimation taken from the haskell track`)

@juhlig
Copy link
Contributor Author

juhlig commented Aug 3, 2018

While it is not hard to come up with a solution that produces correct results, the real challenge of the exercise is doing so in an efficient manner. A solution that is inefficient will probably (depending on the processing power you can muster to throw at it) not pass all tests since they will time out.

@NobbZ What do you think, is that a case where a HINTS.md is justified, with pointers to how to optimize the code (things like "cheap/expensive operations", "skip out early", "reduce overall steps", etc)?

@juhlig juhlig force-pushed the palindrome-products branch from eee4925 to 2ee5668 Compare August 3, 2018 12:09
config.json Outdated
"difficulty": 6,
"topics": [
"algorithms",
"mathematics",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the recent discussion in exercism/exercism#4110, would you mind making this 'math' instead of 'mathematics'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, np, I made the requested changes :)

@juhlig juhlig force-pushed the palindrome-products branch from 2ee5668 to 84a8776 Compare August 4, 2018 16:42
Copy link
Member

@NobbZ NobbZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the HINTS.md is a good start. But I've not done this exercise in any language for ages, and I can not remember having had any runtime issues ever.

@@ -0,0 +1,30 @@
%% Erlang compiler options
{erl_opts, [debug_info]}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add warnings_as_errors here?

@juhlig juhlig closed this Aug 6, 2018
@juhlig juhlig force-pushed the palindrome-products branch from 84a8776 to 445e194 Compare August 6, 2018 07:22
@NobbZ
Copy link
Member

NobbZ commented Aug 6, 2018

May I ask why you have closed the PR?

@juhlig
Copy link
Contributor Author

juhlig commented Aug 6, 2018

Actually, I didn't, don't know how this happened. Can you reopen it?

@juhlig
Copy link
Contributor Author

juhlig commented Aug 6, 2018

oh... it's because the commits disappeared :\ looks like something went very wrong at my end. will check

@juhlig juhlig reopened this Aug 6, 2018
@juhlig
Copy link
Contributor Author

juhlig commented Aug 6, 2018

ok, here it is again, with the warnings_as_errors as requested, and a HINTS.md

@NobbZ
Copy link
Member

NobbZ commented Aug 6, 2018

Thank you!

@NobbZ NobbZ merged commit 4a24e3a into exercism:master Aug 6, 2018
@juhlig juhlig deleted the palindrome-products branch August 7, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants