-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Add .meta/config.json file for concepts #702
🤖 Add .meta/config.json file for concepts #702
Conversation
…`config.json` file containing: - A `blurb` key, which value is copied from the `config.json` file and removed from the `config.json` file - An `authors` key, the value of which is an empty array - A `contributors` key, the value of which is an empty array
4b5ba23
to
b7d9013
Compare
Following a suggestion that was made, we've updated the PR to pre-populate the authors/contributors with the authors/contributors of the exercise that teaches the concept (if any). This gives us a nice starting point, as the concept documents used to be exercise documents. You, the maintainers, should check to see if the authors/contributors are correct and add missing authors/contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angelikatyborska I think you were missed on the concepts that I authored that I'm pretty sure you had a hand in reviewing. Any other changes needed?
@neenjaw I have to reject all of your requests about adding me to those concepts 😅 According to exercism/v3#1335, I was NOT involved in the concepts: According to exercism/v3#1129, I was NOT involved in the concepts: According to exercism/v3#1336, I was NOT involved in the concepts However, you were involved in |
Turns out it was @ErikSchierboom! |
TL;DR; Add authors/contributors to a new
concepts/<slug>/.meta/config.json
to Concepts in the same way you have for Concept Exercises.To properly attribute authorship/contributorship for an individual concept, each concept will have its own
.meta/config.json
file withauthors
andcontributors
keys like those for concept and practice exercises. We're also moving the concept's blurb from the track'sconfig.json
to the.meta/config.json
file, also similar to concept and practice exercises.See https://github.com/exercism/docs/pull/96/files for the update to the specification.
This PR adds a
.meta/config.json
file for all concepts found in the track'sconfig.json
file containing:blurb
key, which value is copied from theconfig.json
file and subsequently removed from theconfig.json
fileauthors
key, the value of which is copied from the exercise teaching the concept (if any)contributors
key, the value of which is copied from the exercise teaching the concept (if any)For ease, the concept's authors/contributors are pre-populated with the authors/contributors of the exercise that teaches the concept (if any).
Maintainers TODO list
These are the things you, the maintainers, should do:
For clarity, authors should be the people who originally created the concept documents on this track. Contributors should be people who have substantially contributed to the concept documents. PRs for typos or multiple-concept PRs do not automatically mean someone should be considered a contributor to that concept. Those non-concept-specific contributions will get recognition through Exercism's reputation system in v3.
You can either update this PR by pushing a new commit to this PR, or merge this and do a follow-up PR later. The former has the disadvantage that once we've added linting rules to
configlet
for the concept.meta/config.json
file, the configlet CI check will start failing.Tracking
exercism/v3-launch#27