Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New concept exercise
dancing-dots
(use
andbehaviour
) #1103New concept exercise
dancing-dots
(use
andbehaviour
) #1103Changes from 23 commits
43d2f23
a1a11e7
98c4faa
ff94fa6
c03269d
a89a48c
7d04120
0ba3a0e
11dafd0
c4575bf
704bb39
0f70635
00c6003
94c3fd6
b15b088
77d19bd
c7122f1
d5b6d46
2099679
6ab5812
3f21f43
faff1bf
1aef4f9
0eea950
5827335
39dee25
def7439
ccfcabe
eebe603
6f789a2
5e79019
362ceec
57f4ca5
44852a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need for an analyzer as well?
The only thing I can thing of is that
DancingDots.Zoom.init/1
usesKeyword
andis_number
but it's very minor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if those two things even matter, using the access behaviour (
opts[:velocity]
) is also fine. I guess the only "bad idea" that technically works would be pattern matching on the keyword list. As foris_number
, we could add more tests that would assert that it also allows floats or something, but I don't think that's really necessary.I could think of two things, relevant to the concept:
362ceec
(#1103)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are better, yes :)