Implementation of isogram, secret-handshake, collatz-conjecture, binary-search #192
Conversation
… also configlet fmt
SahilTara
changed the title
Updated branch with latest commits.
|
Hey, @patricksjackson or @LegalizeAdulthood can one of you please tell me what I need to add/change so that this PR can be merged? |
| @@ -0,0 +1,23 @@ | |||
| #include "binary_search.h" | |||
|
|
|||
| int binary_search::find(const std::vector<int>& arr, int val) { | |||
There was a problem hiding this comment.
shouldn't we return an iterator?
There was a problem hiding this comment.
Sorry for the late reply, I agree to this completely, and if others want an iterator instead we could just use the built in function in std. I was just thinking we'd have the same return type as some other languages when I implemented this.
There was a problem hiding this comment.
I don't think we need to do like other languages. The idea is to learn the language, and the best practice is to return an iterator. I don't want to just use the std function because it teaches less.
| letters.insert(ch); | ||
| } | ||
| // character is a member of the alphabet | ||
| else if (alphabet.find(ch) != alphabet.end()) { |
There was a problem hiding this comment.
The ifs should be the other way round. Also, shouldn't we use isalpha?
|
Obviously we (well, I) am very behind here, since this has been open 6+ months without me addressing it. Sorry. There are really two larger issues here before we can move forward with this PR.
|
|
Closing this for now, feel free to reopen/split this up. |
Hey, I decided to implement some of the exercises needing to be implemented still.
Tell me if anything needs to be changed.
Updated to conform with exercism/exercism#4110 for collatz-conjecture.