Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use QuitSuccess and QuitFailure in quit calls #852

Merged
merged 2 commits into from
Jan 18, 2024
Merged

refactor: use QuitSuccess and QuitFailure in quit calls #852

merged 2 commits into from
Jan 18, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom requested a review from ee7 January 16, 2024 08:37
ee7
ee7 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't checked that this is all of them.

nit: I'd probably omit the parens here. The often-preceding echo and writeLine calls do that too.

@ErikSchierboom
Copy link
Member Author

I've updated

@ee7 ee7 merged commit 4eeb24f into main Jan 18, 2024
12 checks passed
@ee7 ee7 deleted the quit-explicit-argument branch January 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee7 ee7 ee7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikSchierboom @ee7