-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github, config, json, nimble: bump Nim from 1.6.12 to 2.0.0 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
a40ee0f
to
2ad2d54
Compare
I have no idea why this would cause the parseopt3 patching to fail on Windows. Edit: maybe something in nim-lang/Nim@f7c203f#diff-8f98e7617bc9dd47ac179ddec678781d48d70e7f7b9f37f76298ef643f82c690 Edit2: |
485f1cf
to
a7d46f0
Compare
See the release blog posts [1][2][3], detailed changelog [4], and changes since 1.6.12 [5]. [1] https://nim-lang.org/blog/2022/12/21/version-20-rc.html [2] https://nim-lang.org/blog/2023/03/31/version-20-rc2.html [3] https://nim-lang.org/blog/2023/08/01/nim-v20-released.html [4] https://github.com/nim-lang/Nim/blob/v2.0.0/changelogs/changelog_2_0_0_details.md [5] nim-lang/Nim@v1.6.12...v2.0.0
From the Nim 2.0 "changes affecting backward compatibility" [1]: Relative imports will not resolve to searched paths anymore, e.g. `import ./tables` now reports an error properly. [1] https://github.com/nim-lang/Nim/blob/v2.0.0/changelogs/changelog_2_0_0_details.md#changes-affecting-backward-compatibility
Too much noise otherwise.
Nim 2.0 enables strictEffects by default [1]. [1] https://nim-lang.org/blog/2023/08/01/nim-v20-released.html#strict-effects
We had this conditional to support older versions of Nim that lacked strictDefs.
ErikSchierboom
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the release blog posts rc1 and rc2 and 2.0, detailed changelog, and changes since 1.6.12.
config.nims
changes:strictEffects
, which Nim 2.0 enables by default.ProveInit
andUninit
warnings for now.strictDefs
unconditionally. It was previously conditional to support older versions of Nim that lackedstrictDefs
.Update patched stdlib json and parsejson.
In the tests, reflect a Nim 2.0 change to imports. From the changes affecting backward compatibility:
To-do:
nimble test
errors, e.g.:tests/all_tests.nim(2, 11) Error: cannot open file: ./helpers
C:\Users\runneradmin\.nimble\pkgs2\uuids-0.1.11-393f5fcefbc8ad3cf167e59760144208ff8f9f76\uuids\urandom.nim(15, 8) Error: undeclared identifier: 'useWinUnicode'
I've created pragmagic/uuids#9, but that may not be sufficient, and long-term I'd like to do uuid: use best practices for UUID generation #424 instead
json.nim
andparsejson.nim