Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: improve output for choosing tests #352

Merged
merged 4 commits into from
Jun 10, 2021

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Jun 4, 2021

Summary:

  • Move the user's response to the end of the line. It was previously on
    a new line.
  • Remove some unmatched double quotes, and some strange colons.
  • Prompt on stderr.
  • Add two blank link between test cases.

Before this commit:

[warn] isogram: missing 2 test cases
The following test case is missing:"
{
  (omitted for clarity)
}:

Do you want to include the test case ([y]es/[n]o/[s]kip)?:

s
[warn] kindergarten-garden: missing 3 test cases

With this commit:

[warn] isogram: missing 2 test cases
The following test case is missing:
{
  (omitted for clarity)
}

Do you want to include the test case ([y]es/[n]o/[s]kip)? s


[warn] kindergarten-garden: missing 3 test cases

In the future, this is an area where I'd like to add color for clarity (potentially with syntax highlighting for JSON) - I've opened #353.

ee7 added 4 commits June 4, 2021 19:49
There were some strange double quotes and colons.
This is what the Nim style guide currently recommends.
I think prompts are supposed to be on `stderr`. It also means we don't
need to think about `flushFile(stdout)`.
@ee7 ee7 requested a review from ErikSchierboom as a code owner June 4, 2021 17:58
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like it!

@ee7 ee7 mentioned this pull request Jun 10, 2021
4 tasks
@ee7 ee7 force-pushed the sync-improve-readability-in-interactive-mode branch from c552def to 5bd1c17 Compare June 10, 2021 19:49
@ee7 ee7 merged commit 1d6ccf1 into exercism:main Jun 10, 2021
@ee7 ee7 deleted the sync-improve-readability-in-interactive-mode branch June 10, 2021 20:26
@ee7 ee7 changed the title sync: improve readability in interactive mode sync: improve output for choosing tests Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants