lint: check unique array values #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit validates that the following properties don't have any duplicate values: Track config: - `exercises.concept.concepts` - `exercises.concept.prerequisites` - `exercises.practice.practices` - `exercises.practice.prerequisites` Concept Exercise config: - `authors` - `contributors` - `forked_from` Practice Exercise config: - `authors` - `contributors`
ee7
force-pushed
the
check-unique-array-values
branch
from
0a4b30f to
b0eee61
Compare
ee7
approved these changes
May 1, 2021
There was a problem hiding this comment.
Nice. A bunch of extra boxes to tick on the checklist.
Currently, this PR does not change the configlet lint output on any track (currently all these arrays Exercism-wide have distinct elements).
I guess it's easier to accidentally e.g. duplicate a user between authors and contributors.
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #295.
It validates that the following properties don't have any duplicate values:
Track config:
exercises.concept.conceptsexercises.concept.prerequisitesexercises.practice.practicesexercises.practice.prerequisitesConcept Exercise config:
authorscontributorsforked_fromPractice Exercise config:
authorscontributors