Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Nim from 1.4.2 to 1.4.4 #197

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Feb 23, 2021

See the release blog post.


To-do:

  • I'll fix the SSL issue with the Windows CI - the Windows build will currently fail. See this commit: nim-lang/Nim@74d6a4d

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approval pending fixing the Windows build .

@ee7
Copy link
Member Author

ee7 commented Mar 2, 2021

From what I can tell, upstream intends to fix the Windows issue. So I'll wait a bit more before making the fix that will become redundant.

@ee7 ee7 force-pushed the build-nim-1.4.4 branch 2 times, most recently from e636196 to a86ff56 Compare April 9, 2021 16:35
@ee7 ee7 force-pushed the build-nim-1.4.4 branch from a86ff56 to 57dbc5c Compare April 9, 2021 16:50
@ee7 ee7 marked this pull request as ready for review April 9, 2021 16:52
@ee7 ee7 merged commit 909989b into exercism:main Apr 9, 2021
@ee7 ee7 deleted the build-nim-1.4.4 branch April 9, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants