Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4clojure links #391

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Fix 4clojure links #391

merged 1 commit into from
Sep 5, 2021

Conversation

bobbicodes
Copy link
Member

Fixes #388

@bobbicodes bobbicodes requested review from a team and ErikSchierboom September 3, 2021 17:46
ee7
ee7 approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link change looks good to me.

Have you checked that all the docs are up to date? If not, I believe this PR shouldn't close #388.

@bobbicodes
Copy link
Member Author

bobbicodes commented Sep 5, 2021 •
edited
Loading

Have you checked that all the docs are up to date?

They're all working, but I wouldn't mind updating more of them because it's been years since anyone has done so and much has changed.

I'll merge this now but leave the issue open until I'm happy with them.

@bobbicodes bobbicodes merged commit 84f6e9b into main Sep 5, 2021
@bobbicodes bobbicodes deleted the broken-links branch September 5, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee7 ee7 ee7 approved these changes

@ErikSchierboom ErikSchierboom Awaiting requested review from ErikSchierboom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check docs are up to date
2 participants
@bobbicodes @ee7