[sum-of-multiples] update tests to match common test data #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exercise has got common testdata quite a while ago. This commit implements that common testdata in the most recent version. It does not use a generator though.
Due to the changes in the test suite, there was an unused functionclause left in the examples, which gets removed by this commit.
| @@ -5,7 +5,6 @@ | |||
| ([n d] (zero? (rem n d)))) | |||
|
|
|||
| (defn sum-of-multiples | |||
| ([n] (sum-of-multiples [3 5] n)) | |||
| ([multiples n] | |||
There was a problem hiding this comment.
This can/should be refactored into a "simple function," as in without the polyadic clause.
Before it was a multi-clause function with a single clause.
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #107
REF exercism/problem-specifications#198