-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextercism] Implement workspace command #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command implementation is good - just a few minor suggestions on the command descriptions.
cmd/workspace.go
Outdated
@@ -15,16 +16,18 @@ var workspaceCmd = &cobra.Command{ | |||
|
|||
This command can be combined with shell commands to take you there. | |||
|
|||
For example, on Linux or MacOS you can run: | |||
For example you can run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the descriptions could be reworded. I recommend something like
Short: Workspace outputs the path to your configured Exercism workspace.
Long:Workspace outputs a normalized version of the configured Exercism workspace path that can be used for scripting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the repetition of workspace
sounds right, and I'd change outputs
to prints out
, so maybe Print out the path to your Exercism workspace.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robphoenix your version reads better.
30cd07e
to
9f17f3b
Compare
I've given some new wording a go. Would you take one last look at this to see if it reads nicely? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick otherwise 👍
cmd/workspace.go
Outdated
On Windows, the equivalent command is: | ||
|
||
TODO ask @exercism/windows for help | ||
On Windows, this command works in Powershell, however you would need to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference to this command
may be confusing as to whether it is referring to the workspace command or the cd ...
command above. Maybe On Windows, this will work only with Powershell, however ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, yeah that's better.
9f17f3b
to
1062506
Compare
I'll merge this when it goes green. I imagine we'll want to nitpick on all the wording for the entire CLI once we see it in action. |
This adds a simple
workspace
command that outputs the absolute path to the Exercism workspace. This can be composed with thecd
command on Mac, Linux, or in Windows Powershell in order to take the user straight there.Closes #413