[nextercism] Implement prepare command #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kytrinyx
force-pushed
the
nextercism-prepare-cmd
branch
2 times, most recently
from
dbda745 to
c51481a
Compare
kytrinyx
changed the title
|
This is now ready for review. |
kytrinyx
force-pushed
the
nextercism-prepare-cmd
branch
2 times, most recently
from
ca34544 to
f0bf6f2
Compare
robphoenix
approved these changes
Aug 19, 2017
kytrinyx
force-pushed
the
nextercism-prepare-cmd
branch
from
f0bf6f2 to
bbfa058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prepare command will eventually need other things, but I don't know what they are yet. For now, we're just getting the test pattern from the track config so that we can filter files out when we submit them.
The prepare logic will also need to be called from the submit command in the case where we don't have the settings for the track yet. We need this when someone submits a solution by indicating a directory rather than a list of files, so that we can filter out files that shouldn't be submitted.
Closes #418 though I will be opening a new issue to deal with the auto-checking of last version etc, which still needs some hashing out.
We are also hashing out the details of the files to download during track setup (exercism/gnu-apl#6). Once we've got that sorted, I'll open an issue describing what needs to be done.