Nextercism deps #420
Merged
Nextercism deps #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
I'd love to try this with just the lock file and see if we're OK with it. Thoughts? |
|
There may be downsides to that but we can try it and see how it works. If
we run into any issues we could always fix them and move to vendoring the
deps at that point. I'm not near my computer, if you'd like to add a commit
removing the vendor folder and adding to gitignore or I could do it once
I'm back on my computer!
…On Fri, Aug 4, 2017 at 11:54 PM Katrina Owen ***@***.***> wrote:
I'd love to try this with just the lock file and see if we're OK with it.
Thoughts?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#420 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABcA6WDVh3pITaIVbhEr5wDT4wWhphB-ks5sU-degaJpZM4OuUD7>
.
|
I think that sounds like a plan. I'm going to try it! |
|
That worked! If you like this feel free to squash (or not) and merge into the nextercism branch. |
|
We can squash later if needed! 👍 thanks for tackling the removal of vendor and documentation! |
|
Awesome!! 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a time to do this, now is the time...
This switches us over to
depon the nextercism branch. I had issues trying to get things to work smoothly with the newest version of Godep and I've pretty much ripped out the deps we had with Godep and locked them in withdep. Dep ended up adding extra missing dependencies that Godep was not adding and now tests are passing on CI!One thing I noticed is that the
vendorfolder changeset is much bigger than when we were using Godep, not sure why that is yet but that seems to be a con of committing the vendor folder. I think that withdepwe could get away with not doing this since it contains a lockfile but there's still caveats https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory