Changed SNIPPET.txt to be a small standalone program #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
wolf99
reviewed
Jun 13, 2018
docs/SNIPPET.txt
Outdated
|
|
||
| int main(int argc, char* argv[]) { | ||
|
|
||
| for (int i = 1; i <= 5; i++) { |
There was a problem hiding this comment.
Can we get rid of the for loop?
I'd thought the idea of the SNIPPET.md is to provide the simplest program as possible to provide a very basic example. Indeed, I'm assuming this is why you think it should be self-contained? Anyone with no programming experience at all would see a for loop as a pretty arcane piece of symbol garbage. There is nothing wrong with a single line program :)
There was a problem hiding this comment.
Makes sense! I'll get that fixed 👍
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the code snippet to appear more like a standard "Hello, World!" program, which can be compiled and run. I've also included a for loop to make use of the available space in the snippet box.
[Issue #303]