Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove canonical data syncer #503

Merged
merged 3 commits into from
May 4, 2021
Merged

Remove canonical data syncer #503

merged 3 commits into from
May 4, 2021

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented May 4, 2021 •
edited
Loading

The fetch-canonical-data-syncer script is obsolete as canonical data syncing is now built into configlet.

I've also taken the liberty of correcting the call to configlet lint, as the . argument is no longer needed.

See exercism/configlet#124

ee7
ee7 reviewed May 4, 2021
View reviewed changes
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that, with this PR,

$ git grep 'syncer'

produces no output.

@glennj glennj merged commit 0878a65 into main May 4, 2021
@glennj glennj deleted the canonical-data-syncer branch May 4, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ee7 ee7 ee7 left review comments

@glennj glennj glennj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikSchierboom @glennj @ee7