-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ARM64 assembly track's docs, linter, and editor config. #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I've left one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Majority of the suggestions are style related to make these docs match the Exercism Markdown style. Primarily one sentence per line to make future diffs much easier to read.
Looking great so far!!!
"tags": [ | ||
"paradigm/imperative", | ||
"paradigm/procedural", | ||
"typing/static", | ||
"typing/weak", | ||
"execution_mode/compiled", | ||
"platform/android", | ||
"platform/ios", | ||
"platform/mac", | ||
"platform/linux", | ||
"runtime/standalone_executable", | ||
"used_for/embedded_systems", | ||
"used_for/mobile" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
So for the JavaScript track, I created this TAGS.md document to explain to future readers why we tagged with certain tags. This is absolutely optional, but might be nice for those less familiar with this language?
The other changes seem to require manual intervention and discussion. Will get to that in a bit. Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
I don't think I'm ready for that yet. The MIPS assembly track was doing it though but giving it thought seems to show my situation is different.
NOTE: I'm not going to undraft this until I can use the debugger on I've had plenty of ARMv7 experience but I see AArch64 is completely different. Whole other calling convention, etc. but ARM centralizes the docs for both so that makes me very happy. I think the MIPS assembly Exercism contributors struggled with that. They have the MARS emulator though. :) |
A lot has went on. I think this may be ready for review. 📦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Reviewed, but not built.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
Please see the [contributing guide][contributing-guide] | ||
|
||
[contributing-guide]: https://github.com/exercism/x-api/blob/master/CONTRIBUTING.md#the-exercise-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link points to a very old (and deprecated) document. Maybe refer to this document instead:
[contributing-guide]: https://github.com/exercism/x-api/blob/master/CONTRIBUTING.md#the-exercise-data | |
[contributing-guide]: https://exercism.org/docs/building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it, when I get the next PR in
This possibly fixes or backfills fixes beforehand for:
I'm marking this as a draft for now until I have reviewed everything as okay, and then I will make this a true PR. :)