Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing width, class-img-top, class-img-bottom options to grid-item-card #115

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix: Add missing width, class-img-top, class-img-bottom options to grid-item-card #115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e37f44
fix: Add missing width, class-img-top, class-img-bottom options to gr…
jpmckinney Dec 8, 2022
4a59461
Merge branch 'main' into 109-fix-missing-grid-item-card-options
choldgraf Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sphinx_design/grids.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ class GridItemCardDirective(SphinxDirective):
"columns": item_columns_option,
"margin": margin_option,
"padding": padding_option,
"class-item": directives.class_option,
# The options below must be sync'ed with CardDirective.option_spec (minus margin).
"width": make_choice(["auto", "25%", "50%", "75%", "100%"]),
"text-align": text_align,
"img-background": directives.uri,
"img-top": directives.uri,
Expand All @@ -224,12 +227,13 @@ class GridItemCardDirective(SphinxDirective):
"link-type": make_choice(["url", "any", "ref", "doc"]),
"link-alt": directives.unchanged,
"shadow": make_choice(["none", "sm", "md", "lg"]),
"class-item": directives.class_option,
"class-card": directives.class_option,
"class-body": directives.class_option,
"class-title": directives.class_option,
"class-header": directives.class_option,
"class-footer": directives.class_option,
"class-img-top": directives.class_option,
"class-img-bottom": directives.class_option,
}

def run(self) -> List[nodes.Node]:
Expand Down Expand Up @@ -257,6 +261,7 @@ def run(self) -> List[nodes.Node]:
for key, value in self.options.items()
if key
in [
"width",
"text-align",
"img-background",
"img-top",
Expand All @@ -270,9 +275,12 @@ def run(self) -> List[nodes.Node]:
"class-title",
"class-header",
"class-footer",
"class-img-top",
"class-img-bottom",
]
}
card_options["width"] = "100%"
if "width" not in card_options:
card_options["width"] = "100%"
card_options["margin"] = []
card = CardDirective.create_card(self, self.arguments, card_options)
column += card
Expand Down