👌 IMPROVE: Add parsed_directive and parsed_role parent tokens
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
rowanc1
reviewed
Mar 28, 2022
| token.content.trim() ? token.content.split(/\r?\n/) : [], | ||
| directive | ||
| ) | ||
| const directiveOpen = new state.Token("parsed_directive_open", "", 1) |
rowanc1
approved these changes
Mar 28, 2022
Comment on lines
+73
to
78
| // Ensure `meta` exists and add the directive options to parsed child | ||
| newTokens[1].meta = { | ||
| directive: true, | ||
| ...data.options, | ||
| ...newTokens[0].meta | ||
| ...newTokens[1].meta | ||
| } |
There was a problem hiding this comment.
As just discussed, I don't think we need this any more, since you can retrieve this info from the (directive) parent node.
|
Cheers guys, so yep as we have just discussed, this change ties into: #31 (comment): In order to not lose the information, of what nodes were generated from directives/roles, we now include a parent node, e.g. <admonition class="note" directive="true">
...will now be output as: <parsed_directive name="note">
<admonition class="note">
... |
chrisjsewell
approved these changes
Mar 29, 2022
chrisjsewell
changed the title
parsed_directive and parsed_role parent tokens
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
parsed_directiveandparsed_roletokens to wrap parsed contentlegendtokens for paragraphs aftercaptionin figureOther context here:
#31 (comment)