Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting required env variables for local mode #685

Merged
merged 1 commit into from
Oct 2, 2023
Merged

setting required env variables for local mode #685

merged 1 commit into from
Oct 2, 2023

Conversation

jmilkiewicz
Copy link
Contributor

Fixes possibilty to run lighter in local mode. Till now env variables like:

  • PY_GATEWAY_PORT
  • PY_GATEWAY_HOST
  • LIGHTER_SESSION_ID
    were not passed to shell_wrapper.py

This PR does not solve the problem of:

  • setting custom env variables on session creation
  • setting custom env variables on statement creation

@jmilkiewicz jmilkiewicz changed the title setting needed env variables for local mode setting required env variables for local mode Oct 2, 2023
@jmilkiewicz
Copy link
Contributor Author

More context can be found #682

@pdambrauskas pdambrauskas merged commit 7853e0c into exacaster:master Oct 2, 2023
@jmilkiewicz jmilkiewicz deleted the fix-env-variables-local branch October 2, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdambrauskas pdambrauskas pdambrauskas approved these changes

@Minutis Minutis Awaiting requested review from Minutis Minutis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmilkiewicz @pdambrauskas