Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve Dockerfile and remove vuln #658

Merged
merged 3 commits into from
Sep 11, 2023
Merged

feat: improve Dockerfile and remove vuln #658

merged 3 commits into from
Sep 11, 2023

Conversation

julienlau
Copy link

improve Dockerfile in a security perspective:

  • remove obsolete openjdk base image
  • use node version that do not include critcal vulnerabilities
  • specify UID >= 10000
  • remove wget and curl (we may skip this step)
  • solve an issue due to procps not being installed
  • install atop basic monitoring tool

I checked on my environments that the image is functionnal

Minutis
Minutis reviewed Sep 7, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Minutis
Minutis reviewed Sep 8, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Minutis
Minutis reviewed Sep 8, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@julienlau
Copy link
Author

Please find a new commit that I tested on my side and is OK.
It takes your review into account

Minutis
Minutis approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@Minutis Minutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pdambrauskas pdambrauskas merged commit 295f8b8 into exacaster:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minutis Minutis Minutis approved these changes

@pdambrauskas pdambrauskas Awaiting requested review from pdambrauskas pdambrauskas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienlau @Minutis @pdambrauskas @pepitedata