Bump elixir version #959
Closed
Bump elixir version #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Elixir 1.15 is out, 1.10 is not supported anymore. This also allows us to get rid of deprecation warnings. https://hexdocs.pm/elixir/1.15.0/compatibility-and-deprecations.html
|
It might also not be productive to bump the minimum version unless there is an actual reason. The only requirement from my knowledge is using the Req library in another PR, but Finch is fine with 1.7 afaik. |
|
Ah dang, I totally forgot you'd already done this and I made a bunch of similar changes. Not nearly as thorough as yours, though. Let me get this merged. Thanks! |
Merged
|
Thanks again @wkirschbaum - I've rebased this and merged it in #975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Elixir 1.15 is out, 1.10 is not supported anymore. This also
allows us to get rid of deprecation warnings.
https://hexdocs.pm/elixir/1.15.0/compatibility-and-deprecations.html