Refactor waitForExist to resolve immediately, handle nested selectors and more #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, handle functions as selectors, and provide better error messages showing which selectors were not found and which variant the error happened in.
|
@teolisitza @phylliswong @joshua-barnard-evolv^^ I also think we should set this repo up with a thoughts? |
timcubb
changed the title
timcubb
changed the title
teolisitza
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor waitForExist to resolve immediately, handle nested selectors, handle functions as selectors, and provide better error messages showing which selectors were not found and which variant the error happened in.