Skip to content

Commit

Permalink
🐛 Fix: maxPriorityFeePerGas issue (#1500)
Browse files Browse the repository at this point in the history
## Description

_Concise description of proposed changes_

## Testing

Explain the quality checks that have been done on the code changes

## Additional Information

- [ ] I read the [contributing docs](../docs/contributing.md) (if this
is your first contribution)

Your ENS/address:



<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Simplified redirect configuration for `/telegram`, enhancing clarity
and ease of use.
  
- **Documentation**
- Updated the `requestProcedure` function documentation for improved
clarity and context.
  - Added a new reference section to guide users on related topics.

- **Bug Fixes**
- Enhanced transaction fee calculation logic to ensure accurate gas fee
handling.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
roninjin10 authored Dec 2, 2024
1 parent dc15893 commit 1410ecb
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
7 changes: 2 additions & 5 deletions docs/astro.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ export default defineConfig({
starlightConfig,
],
redirects: {
'/telegram': {
destination: 'https://t.me/+ANThR9bHDLAwMjUx',
permanent: true
}
}
'/telegram': 'https://t.me/+ANThR9bHDLAwMjUx',
}
});

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions packages/actions/src/internal/evmInputToImpersonatedTx.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ export const evmInputToImpersonatedTx = (client) => {
if (_maxFeePerGas < baseFeePerGas) {
_maxFeePerGas = baseFeePerGas
}
if (maxPriorityFeePerGas && _maxFeePerGas < maxPriorityFeePerGas) {
_maxFeePerGas = maxPriorityFeePerGas
}

// TODO we should be allowing actual real signed tx too here
// TODO known bug here we should be allowing unlimited code size here based on user providing option
Expand Down

0 comments on commit 1410ecb

Please sign in to comment.