Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intrarelayer proposals are not registered #121

Merged
merged 26 commits into from
Dec 1, 2021
Merged

Conversation

hanchon
Copy link
Contributor

@hanchon hanchon commented Nov 26, 2021

Closes: #119

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@linear
Copy link

linear bot commented Nov 26, 2021

ENG-292 can't submit intrarelayer proposal with CLI

evmosd tx gov submit-proposal
Error: invalid message: can't proto marshal <nil>
Usage:
  evmosd tx gov submit-proposal [flags]
  evmosd tx gov submit-proposal [command]

Available Commands:
  cancel-software-upgrade Cancel the current software upgrade proposal
  community-pool-spend    Submit a community pool spend proposal
  ibc-upgrade             Submit an IBC upgrade proposal
  param-change            Submit a parameter change proposal
  software-upgrade        Submit a software upgrade proposal
  update-client           Submit an update IBC client proposal

@hanchon
Copy link
Contributor Author

hanchon commented Nov 26, 2021

I'm doing a complete proposals test on my local testnet, after I made sure everything is working as intended I'll change the pr status.

NOTE: this PR is a breaking change because the previous version will just assume that the IRM module is not enabled. (Cause it can not read the stored params)

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #121 (04b5eea) into main (cced9ed) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   72.04%   72.43%   +0.39%     
==========================================
  Files          23       24       +1     
  Lines        1692     1698       +6     
==========================================
+ Hits         1219     1230      +11     
+ Misses        419      416       -3     
+ Partials       54       52       -2     
Impacted Files Coverage Δ
app/app.go 80.68% <100.00%> (+0.08%) ⬆️
x/intrarelayer/keeper/migrations.go 100.00% <100.00%> (ø)
x/intrarelayer/keeper/proposals.go 89.88% <100.00%> (ø)
x/intrarelayer/types/proposal.go 92.85% <100.00%> (ø)
x/intrarelayer/keeper/evm_hooks.go 54.79% <0.00%> (+6.84%) ⬆️

@github-actions github-actions bot added the CLI label Nov 26, 2021
@fedekunze fedekunze changed the title gov router needs irm reference because it's has no value yet fix: intrarelayer proposals are not registered Nov 26, 2021
@fedekunze fedekunze marked this pull request as ready for review November 29, 2021 14:02
@fedekunze fedekunze merged commit 587f351 into main Dec 1, 2021
@fedekunze fedekunze deleted the ENG-292-IRM-Proposals branch December 1, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error register ERC20 proposal (Intrarelayer)
3 participants