chore: Check the signature returned by the ledger device against the …

…public key in the keyring (cosmos#14460) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo Medica <[email protected]>
evmos · Jan 2, 2023 · 03196d7 · 03196d7
1 parent bca18ba
commit 03196d7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/crypto/keyring/keyring.go b/crypto/keyring/keyring.go
@@ -616,6 +616,10 @@ func SignWithLedger(k *Record, msg []byte) (sig []byte, pub types.PubKey, err er
 		return nil, nil, err
 	}
 
+	if !priv.PubKey().VerifySignature(msg, sig) {
+		return nil, nil, errors.New("Ledger generated an invalid signature. Perhaps you have multiple ledgers and need to try another one")
+	}
+
 	return sig, priv.PubKey(), nil
 }