-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReferenceLine
/ReferenceArea
to use a store, prop parity with ReferencePoint
#2184
Conversation
🦋 Changeset detectedLatest commit: f94e6d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for next-docs-evidence ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-test-env ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c9c20af
to
467258a
Compare
packages/ui/core-components/src/lib/unsorted/viz/references/ReferenceArea/ReferenceArea.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/unsorted/viz/references/ReferenceArea/ReferenceArea.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/unsorted/viz/references/ReferenceArea/reference-area.d.ts
Outdated
Show resolved
Hide resolved
...ges/ui/core-components/src/lib/unsorted/viz/references/ReferenceArea/reference-area.store.js
Outdated
Show resolved
Hide resolved
@ItsMeBrianD Let's have a conversation about what we want to do with the stores. I'm not sure that converting them to classes (or 1 class) like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall works well aside from one unintentional breaking change
We will also need to update the docs reference for RefLine/Area where additional props are available
packages/ui/core-components/src/lib/unsorted/viz/references/ReferenceLine/_ReferenceLine.svelte
Show resolved
Hide resolved
@archiewood This is done, see the diff for |
3f2ad54
to
a891660
Compare
a891660
to
8f5c57c
Compare
8f5c57c
to
a9207a6
Compare
also adds support for customizing start/end of symbol separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Easy review with storybook
Description
Checklist