POC: Preemption Toleration Plugin Implementation and Tests #2
Conversation
everpeace
force-pushed
the
preemption-toleration-kep
branch
2 times, most recently
from
fcc90e3 to
3465f9a
Compare
everpeace
force-pushed
the
preemption-toleration-impl
branch
from
755bf93 to
8b4b6b8
Compare
everpeace
force-pushed
the
preemption-toleration-kep
branch
2 times, most recently
from
1820505 to
599614e
Compare
everpeace
force-pushed
the
preemption-toleration-impl
branch
from
8b4b6b8 to
245aa60
Compare
everpeace
force-pushed
the
preemption-toleration-kep
branch
from
599614e to
63b20e7
Compare
everpeace
force-pushed
the
preemption-toleration-impl
branch
from
245aa60 to
4a029e0
Compare
everpeace
changed the title
| } | ||
|
|
||
| // check it can tolerate the preemption in terms of priority value | ||
| canTolerateOnPriorityValue := preemptorPriority < *pt.MinimumPreemptablePriority |
There was a problem hiding this comment.
pt can be nil when the priority class does not have the toleration policy annotation.
| // check it can tolerate the preemption in terms of toleration seconds | ||
| _, scheduledCondition := podutil.GetPodCondition(&victimCandidate.Status, v1.PodScheduled) | ||
| if scheduledCondition == nil { | ||
| // if victim is not scheduled, skip evaluating tolerationSeconds |
There was a problem hiding this comment.
In what case a pod becomes a victim candidate even though it has not been scheduled yet?
There was a problem hiding this comment.
I misunderstood that nominated pods would be passed here. It should not happen here. But I would like to keep this guard. So, I will just delete the comment. Thanks for the catch.
| if tt.canTolerate { | ||
| // - the victim candidate pod keeps being scheduled, and | ||
| // - the preemptor pod is not scheduled | ||
| if err := wait.Poll(1*time.Second, 30*time.Second, func() (bool, error) { |
There was a problem hiding this comment.
wait.Poll() returns immediately once the given condition function returns true, but here we should assert that the function continuously returns true for some seconds instead.
There was a problem hiding this comment.
Correct. I will fix this gomega's Consistently like assertion.
|
@ordovicia @shioshiota I fixed things commented. PTAL. |
everpeace
force-pushed
the
preemption-toleration-impl
branch
from
c1d51fa to
a5cf119
Compare
|
squashed. |
everpeace
force-pushed
the
preemption-toleration-impl
branch
2 times, most recently
from
4582a67 to
b97edf6
Compare
everpeace
force-pushed
the
preemption-toleration-kep
branch
3 times, most recently
from
f8042eb to
cd1f519
Compare
everpeace
force-pushed
the
preemption-toleration-kep
branch
4 times, most recently
from
4fae905 to
aa22f0c
Compare
…ration-kep KEP: Preemption Toleration Plugin
because most of identical code is needed but they're not exposed.
everpeace
force-pushed
the
preemption-toleration-impl
branch
from
b97edf6 to
66a6703
Compare
|
I close this PR and delete the |
This PR is a PoC implementation of "Preemption Toleration" plugin proposed in (kubernetes-sigs#205).
Many code is borrowed from default preemption plugin in kube-scheduler because this plugin requires almost identical logics with this but most of them are not exposed. I believe kubernetes/kubernetes#95131 resolves it.